This forum is in READ-ONLY mode.
You can look around, but if you want to ask a new question, please use the new forum.
Home » plugins » General plug-ins » new minify plugin
new minify plugin [message #79093] Thu, 28 May 2009 14:13 Go to next message
allyb  is currently offline allyb
Messages: 21
Registered: May 2009
Junior Member
hi,

i created a new plugin based on the existing sfminifyplugin. it's almost the same, except that the files produced have unique names based on the modification timestamps of the combined files. this allows you to set far-future expiry dates on the combined files.

the plugin is call sfMinifyTSPlugin - TS is for time stamp.

ally
Re: new minify plugin [message #90418 is a reply to message #79093 ] Wed, 23 December 2009 21:02 Go to previous messageGo to next message
jmerhar  is currently offline jmerhar
Messages: 26
Registered: March 2007
Location: Slovenia
Junior Member
Hi, allyb,

I've tried your plugin and I like it a lot, but I do have some observations I would like to share with you.

1. The plugin doesn't seem to respect CSS conditions. In my view.yml, I have something like this:
stylesheets:
  - ...
  - ie6: { media: all, condition: lt IE 7 }

In this case, the plugin (correctly) doesn't include this file in the combined minified file, but instead of including it like this:
<!--[if lt IE 7]><link rel="stylesheet" type="text/css" media="all" href="/css/ie6.css" /><![endif]-->

it does this:
<link rel="stylesheet" type="text/css" media="all" condition="lt IE 7" href="/css/ie6.css" />

This looks like a bug in the plugin. On the other hand, it doesn't seem to support this option at all for javascript files:
javascripts:
  - ...
  - ie7: { condition: lt IE 7 }

Symfony handles this configuration option correctly, and wraps the javascript in a conditional comment, but your plugin seems to ignore it.



2. Would it be possible to add an option to use YUI Compressor instead of JSMin? Apparently, the minify library already supports this.


Thanks for an excellent plugin, and I hope you will address these small issues.
Re: new minify plugin [message #102719 is a reply to message #79093 ] Mon, 19 July 2010 10:21 Go to previous message
andichirita  is currently offline andichirita
Messages: 2
Registered: July 2010
Junior Member
Great plugin,
I like the idea with the cash folder and all the new minify:clear-cache.

There are some small bugs:

1) I have some external .js in my view.yml (like jquery on google code) and it doesn't exclude it for compression. The plugin gives an error mistaking combining all script as one (external.js, intern1.js, intern2.js like one source).

2) For me the plugin worked only when I activated the "compressed: on" in settings.yml.

3) minify:fix-permissions exits? I only have minify:permissions

I will truly grateful If you can answer my questions.
Smile
Previous Topic:sfLESSPlugin absolute path issues
Next Topic:how do you install fpdf
Goto Forum:
  

powered by FUDforum - copyright ©2001-2004 FUD Forum Bulletin Board Software